angular / angular/components

bug(mat-form-filed): padding added to mat-icon when used as a prefix/suffix does not respect density

未关闭
#26,529 1 条评论 8 个 reaction 已指派 0 人 在 GitHub 查看
area: material/icon P3
主要语言
TypeScript
星标
25k
派生
6.8k
平均合并
1 天 8 小时
30 天内合并 PR
91

描述

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

Any mat-icon with the matPrefix or matSuffix directive applied to it appears to always have this rule
.mat-mdc-form-field-icon-prefix>.mat-icon, .mat-mdc-form-field-icon-suffix>.mat-icon {
padding: 12px;
box-sizing: content-box;
}
This padding is always the same no matter what density used used for the mat-form-field. Causes form-fields to be taller then they should be when they have an mat-icon prefix/suffix and using smaller densities. Aligns the actual input at the top of the form-field.

### Reproduction

Steps to reproduce:
1. Set density for mat-form-field to minimum
2. Create an mat-form-field with a mat-icon as its mat-suffix

https://stackblitz.com/edit/angular-wxbcwr-7qsjkw?file=src%2Fapp%2Finput-prefix-suffix-example.html

The example contains 3 fields, first one uses a mat-icon-button instead of a mat-icon directly, second uses a mat-icon, 3rd wraps the mat-icon in a span.

In cases 1 and 3 no padding is applied, in the second one 12 pixels of padding is applied to the mat-icon regardless of density settings.

### Expected Behavior

Padding applied to mat-icon with a matSuffix/matPrefix directive should be adjusted based on the density of the mat-form-field

### Actual Behavior

Padding for a mat-icon with a matSuffix/matPrefix directive is always 12 pixels.

### Environment

- Angular:
- CDK/Material:
- Browser(s):
- Operating System (e.g. Windows, macOS, Ubuntu):

贡献指南

打开贡献指南

调研方向

先从 issue 中描述的 .mat-mdc-form-field-icon-prefix > .mat-icon 和 .mat-mdc-form-field-icon-suffix > .mat-icon 规则开始,然后至少在链接的 StackBlitz 中以最小密度复现这三个案例。完成的标准是,直接的 mat-icon 前缀和后缀 padding 会随 form-field 密度变化,同时 mat-icon-button 和 wrapped-icon 案例保持当前行为不变。

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, css, typescript
领域
frontend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。