angular / angular/components

feat(datepicker-actions): option to close on date selection or expose selectedChange on datepicker

Abierto
#23,593 10 comentarios 2 reacciones 0 asignados Ver en GitHub
area: material/datepicker feature P3
Lenguaje dominante
TypeScript
Estrellas
25k
Forks
6.8k
Merge medio
1 d 8 h
PR fusionados (30 d)
91

Descripción

#### Feature Description

Currently when a datepicker has a datepicker-actions component in it's content, it blocks the datepicker from closing on date selection. I'd like a way to have datepicker-actions in my datepicker component but still get the close on date selection behavior. There are 2 ways that I see of accomplishing this.

**Expose the `selectedChange` event that already exists on mat-calendar**
If the user had access to this they would easily be able to close the datepicker manually. Here's a usage example:
```html


Some static content for the user to read in the datepicker

```
It also makes sense to expose this now because before `datepicker-actions` the `datepicker` would close on selection, but now that it's held open, an app may need to do some logic on selection change and this would enable that.

**Add `closeOnSelection` input to `mat-datepicker-action`

Simply add a boolean input that allow datepicker-actions to be configured to close on selection. This one is more straightforward and probably easier for consumers to understand but not as versatile as the above solution.

#### Use Case

The most common use case would be when a consumer wants to put static content in the footer of the datepicker. Personally I am using `dateClass` to highlight dates I want to recommend for the user and want to put a key in the footer to describe what the different highlighted colors are supposed to indicate. I currently have to also add a `SELECT` and `CANCEL` button due to the way the datepicker behaves with actions, so my footer much bigger than it needs to be and the user has an extra click for each date they select.

#### Work

I've contributed before and have a pretty good idea how to implement either of the options presented above. So if the material team is interested please let me know which option would be best and I can start a PR.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza rastreando la interacción entre mat-datepicker, el evento selectedChange de mat-calendar y mat-datepicker-actions, utilizando como puntos de entrada los dos enfoques de API descritos en el issue. Se considera terminado cuando el comportamiento preferido por los maintainers esté implementado con una API clara orientada al consumidor y el datepicker siga admitiendo contenido estático en el pie de página sin requerir controles de selección adicionales.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
frontend
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.