angular / angular/components

bug(overlay): Push calculation is wrong with FlexibleConnectedPositionStrategy

Abierto
#20,890 3 comentarios 0 reacciones 0 asignados Ver en GitHub
area: cdk/overlay P3
Lenguaje dominante
TypeScript
Estrellas
25k
Forks
6.8k
Merge medio
1 d 8 h
PR fusionados (30 d)
91

Descripción

## Bug description

Push calculation is wrong [in this line](https://github.com/angular/components/blob/0b2d150339fb6e5736ea199bc62785ec1d2e8928/src/cdk/overlay/position/flexible-connected-position-strategy.ts#L614). Maybe in the next lines also, but I did not check it yet.

I tried to add an element, that perfectly fits, but I could not. I realized that the double of the original margin is used on the right side. I used LTR.

### Input

Take a document, that has 400px width. The margin is 20px on the viewport of the overlay. I tried to add one overlay at (300, 20) with size of (80,40). I will use this in the stackblitz and in the calculations.

#### Reproduction

https://stackblitz.com/edit/angular-ardamx

![overlay](https://user-images.githubusercontent.com/6360699/97225389-df307d00-17d2-11eb-8399-e5a339d20aca.gif)

As you see the overlay is positioned well at the begining. 100px is the container. 80px is the overlay. 10-80-10 is well positioned.

If the body element is 420px width, the position is right. 0-80-20.

If the body is shrinked more to 400px, the position will not be 0-80-20, however it could fit.

#### Expected Behavior

pushX to be 0 in this case. The element should fit without pushing it. The margin should be 20px on the right, too.

#### Actual Behavior

start.x is 300, the width is 80 as these are given. The viewport width is 360px (=400px-2*20px).

pushX will be -20 as overflowRight is 20. This is calculated by 300+80-360=20.

This is wrong. The element can fit without pushing it. The margin is now the double of the originally given, which is 40px in this case.

#### Environment

- Angular: 10.1.3
- CDK/Material: 10.2.5
- Browser(s): Chrome (Could be any)
- Operating System (e.g. Windows, macOS, Ubuntu): macOS (Could be any)

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en src/cdk/overlay/position/flexible-connected-position-strategy.ts, en la línea enlazada del cálculo de push, usando la reproducción de StackBlitz y el viewport indicado de 400px, el margen de 20px y el overlay de 80px. Rastrea los cálculos de desbordamiento circundantes y verifica que el overlay quepa con un margen derecho de 20px; se considera terminado cuando pushX permanece en 0 en este caso sin introducir un margen adicional.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
frontend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.