angular / angular/components

question(drag-drop): createEmbeddedView for drag preview/placeholder templates

未关闭
#20,047 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
area: cdk/drag-drop P3
主要语言
TypeScript
星标
25k
派生
6.8k
平均合并
1 天 8 小时
30 天内合并 PR
91

描述

A few months back, I opened https://github.com/angular/components/issues/19060 that described a bug with `matchSize` possibly not working correctly due to the preview template being stamped out inside the drop list's view container...and afterward measuring the original drag item.

The solution I proposed in that thread was to just stamp out the preview template view outside of the DOM, so the drop list container children are never touched before being measured.

The fix for this issue was decided to be to measure the original drag item first, then stamp the preview template out in the existing manner in the drop list view container. This works, but the implementation still bugs me because the template is being stamped out in the view container, modifying the DOM, and then the drag preview element is immediately moved to bottom of the document body, modifying the DOM **again** (versus the other solution that only modifies the DOM once). Same idea for the placeholder template as well, how it is placed into the DOM and then immediately moved around (using `replaceChild`)...when it could just be put in the correct place from the start.

@crisbeto made the following comment:
>The idea behind inserting the view through the ViewContainerRef is to ensure that it's inside the same view/DI hierarchy as drag item. I agree that ideally we'd just create the element outside the DOM, but an alternate solution is to measure the element before the preview has been created.

but I am struggling to understand this comment (_"ensure that it's inside the same view/DI hierarchy as drag item"_). As far as I am aware, an injector cannot be specified when using `createEmbeddedView` and the injector used inside the preview template is simply the injector of the component in which the template is **defined**.

Issue about this (still open...) from 3 years ago:
https://github.com/angular/angular/issues/14935

So what would stamping a template out using
```ts
const viewRef = previewConfig!.viewContainer.createEmbeddedView(previewTemplate, previewConfig!.context);
```
or
```ts
const viewRef = previewTemplate.createEmbeddedView(previewConfig!.context);
```

have anything to do with dependency injection? I feel like the answer is "nothing" but I might be misunderstanding.

@crisbeto can you explain your comment in more detail as to why it is advantageous to use the view container and/or if something I've said above is not accurate?

贡献指南

打开贡献指南

调研方向

从这里所述的拖拽预览和占位符创建路径入手,对比 ViewContainerRef.createEmbeddedView 与 TemplateRef.createEmbeddedView,以及现有的测量和 reparenting 顺序。完成标准是获得经维护者确认的 DI/视图层级行为说明,并确定一个方向;issue 中没有指定文件或测试。

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, typescript
领域
frontend
Issue 类型
重构
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。