angular / angular/components

MatIcon `inline` doesn't work with `svgIcon`

Aperta
#16,483 3 commenti 11 reazioni 0 assegnatari Vedi su GitHub
area: material/icon P3
Lingua principale
TypeScript
Stelle
25k
Fork
6.8k
Merge medio
1g 8h
PR unite (30g)
91

Descrizione

#### Reproduction

https://stackblitz.com/edit/angular-s9aswa

#### Expected Behavior

Loading an icon via SVG and displaying it `inline` should make its size proportionate to the text.

#### Actual Behavior

The size of the icon did not change and the icon's position broke.

I think it has to do with how the SVG has `width: 100%; height: 100%` applied to it:

https://github.com/angular/components/blob/738f10c9931642469f3699d4c8ff50b1e66a960e/src/material/icon/icon-registry.ts#L525

Maybe it could change to `1em` for `inline` icons?

Alternatively if `inline` is not supported for `svgIcon` then it should be documented.

Note: I had to inline the SVG as base64 because the original StackBlitz is broken - I will open another issue for this.

#### Environment

- Angular: Docs Stackblitz (8.1.0)
- CDK/Material: Docs Stackblitz (8.0.2)
- Browser(s): Chrome 75
- Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with the linked StackBlitz reproduction, then inspect src/material/icon/icon-registry.ts around line 525, where SVG sizing is applied. Confirm how inline SVG icons behave with svgIcon and establish whether the final result should make the icon proportionate to surrounding text or document that combination as unsupported.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
frontend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.