angular / angular/components

mat-chip with autocomplete can add unwanted chips

未关闭
#13,574 12 条评论 15 个 reaction 已指派 0 人 在 GitHub 查看
area: material/autocomplete area: material/chips P4
主要语言
TypeScript
星标
25k
派生
6.8k
平均合并
1 天 8 小时
30 天内合并 PR
91

描述

#### Bug, feature request, or proposal:
Bug

#### What is the expected behavior?
Typing a partial search term, using arrow keys to highlight option on autocomplete list, and pressing Enter should add only the selected chip.

#### What is the current behavior?
Intermittently, two chips are added. One for the selected value and one with the partial search term.

#### What are the steps to reproduce?
Providing a StackBlitz reproduction is the *best* way to share your issue.

StackBlitz starter: https://goo.gl/wwnhMV

I tried creating a StackBlitz to reproduce it, but couldn't get it to reproduce. Then I realized that it's a race condition causing it. More below...

#### What is the use-case or motivation for changing an existing behavior?
Addtional chip is unexpected behavior

#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular/Material >= v6 for sure.

#### Is there anything else we should know?
The problem happens depending on the order that event handlers get executed. The code from the [official example](https://stackblitz.com/angular/klblpljogjd) expects the optionSelected event of the mat-autocomplete to execute first (which clears out the input box), then for the matChipInputTokenEnd event of the input to execute (which avoids adding a chip if it's blank).

For whatever reason, using the exact same code and framework version in my app, the event handlers execute in the opposite order. Since the input hasn't been cleared yet, the search term gets added as an unexpected chip. Then the option from the autocomplete gets added as the expected chip.

贡献指南

打开贡献指南

调研方向

Start with the official Angular Material autocomplete and chips example, then trace the matChipInputTokenEnd and optionSelected event handlers and their execution order. Reproduce the race on Angular/Material v6 or later and verify that pressing Enter after selecting an option adds only the selected chip, not the partial search term.

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, typescript
领域
frontend
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。