Radio Button with object as value uncheckes on reset/setvalue/patchvalue
- 主要语言
- TypeScript
- 星标
- 25k
- 派生
- 6.8k
- 平均合并
- 1 天 8 小时
- 30 天内合并 PR
- 91
描述
#### Bug, feature request, or proposal:
Bug
#### What is the expected behavior?
Just read the next part it will become obvious.
#### What is the current behavior?
When using objects as the value for MatRadioGroup and MatRadioButton the current implementation lacks a `compareWith` property like the current implementation of MatSelect. Normally the radio button will only do a reference based comparison of the value compared to the radio groups value to see if a button should be checked. This is an issue because I am using an API to get the values for the radio group and buttons this interferes with this way of doing a comparison.
However MatRadioButton does have a property called `checked` which I can use. I wrote my own compare method and have it check the current value of the MatRadioGroup with the current value of the MatRadioButton and return true to set the `checked` state of the radio button.
When I use `reset(value)`, `setValue(value)`, or `patchValue(value)` or click on a radio to change the value of the MatRadioGroup, everything works. However performing this twice with the same object results in the radio being unchecked.
#### What are the steps to reproduce?
https://stackblitz.com/edit/angular-material-radio-not-checked-bug
Press the set button twice.
OR
Press the set button then press the reset button twice
OR
Change the selected radio by clicking on a new option and then press the reset button twice
OR
Do not change anything and right away (after a fresh page load) press the reset button
#### What is the use-case or motivation for changing an existing behavior?
Allowing me to use objects or arrays with MatRadioGroup/MatRadioButton while preserving the functionality of a simple reset button for my form.
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?
material 5 and 6
#### Is there anything else we should know?
This may be related to:
https://github.com/angular/material2/issues/11368
I also think that this feature request would also help potentially fix this issue depending on implementation:
https://github.com/angular/material2/issues/10495
贡献指南
调研方向
从链接的 StackBlitz 复现开始,检查 MatRadioGroup 和 MatRadioButton 对 value/checked 的处理。使用对象值重复调用 reset、setValue 和 patchValue,然后跟踪第二次更新的比较方式。当选中的单选按钮在每次重复更新后以及更改选项后仍保持选中状态时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- angular, typescript
- 领域
- frontend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100