DateAdapter: issues with setLocale(..) in main vs. lazy loaded module
- Lenguaje dominante
- TypeScript
- Estrellas
- 25k
- Forks
- 6.8k
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 91
Descripción
#### Bug, feature request, or proposal:
Bug (probably, otherwise docs need to be updated to clarify this behavior).
#### What is the expected behavior?
I expect the entire application to be in a certain locale, thus it should be enough to set it **once** using the DateAdapter's `setLocale(..)`.
#### What is the current behavior?
Apparently the `DateAdapter` is not a single instance, but rather lazy modules get their own instance. As a result, setting the locale (like in the `app.component.ts` might not work (as one expects) when loading some components within a lazy loaded module (via routing).
#### What are the steps to reproduce?
Here's a Stackblitz to reproduce the issue: https://stackblitz.com/edit/angular-material-datepicker-locale?file=src%2Fapp%2Fapp.component.ts
1. Clicking the "test" link loads the lazy `/test` route. Both, `app.module` and `lazy.module` import `SharedModule` which imports the Material stuff.
1. The datepicker is in English by default. Clicking the button "set locale on app module" should set it to German, but it doesn't.
1. Clicking the button "set locale in lazy module" however works as expected.
That makes me think there are 2 instances of the `DateAdapter`, one for the lazy module and one for the app module.
#### What is the use-case or motivation for changing an existing behavior?
Usually the locale is very much related to the application language. In most cases you load the user profile when the app starts and based on his settings, cookies or whatever, you set the language and locale respectively. Similarly at the same point you also want to adjust other components' locales such as the Material Datepicker.
The current behavior however is misleading, as one might expect that setting the locale on the `DateAdapter` object should automatically adjust them for all datepickers. Due to the bug that is not the case for lazy loaded modules however.
#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Guía de contribución
Línea de trabajo
Comienza con la reproducción de StackBlitz, especialmente con app.component.ts, app.module, lazy.module y las importaciones de SharedModule. Rastrea cómo se proporciona DateAdapter en los módulos principal y de carga diferida, y luego verifica que establecer la locale en la aplicación afecte a los datepickers en ambas rutas. Se considera terminado cuando la reproducción se comporta de forma coherente o el comportamiento está documentado claramente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- angular, typescript
- Área
- frontend, localization
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100