angular / angular/angularfire

Code in schematics/deploy/builder.ts is preventing the usage of any non-default firebaseProject and firebaseHostingSite values

未關閉
#3,077 11 則留言 16 個 reaction 已指派 1 人 已被 @davideast 認領 在 GitHub 檢視
comp: schematics type: bug version: legacy (v7-v16)
主要語言
TypeScript
星號
7.8k
分支
2.2k
平均合併
22 小時 28 分鐘
30 天內合併 PR
6

描述

### Version info

**Angular:**
13.0.3

**Firebase:**
0.22.0

**AngularFire:**
7.2.0

**Other (e.g. Ionic/Cordova, Node, browser, operating system):**
Node:
v16.13.0

### How to reproduce these conditions

Trying to accomplish working with multiple firebase projects for deployment as per instructions here: https://stackblitz.com/edit/angular-fire-start

**Steps to set up and reproduce**

When I try to set the different configurations for deploy command - for example:
```
"deploy": {
"builder": "@angular/fire:deploy",
"options": {
"prerender": false,
"ssr": false,
"browserTarget": "mypage:build:staging",
"firebaseProject": "mypage-stg",
"firebaseHostingSite": "mypage-stg"
},
"configurations": {
"production": {
"browserTarget": "mypage:build:production",
"firebaseProject": "mypage-prod",
"firebaseHostingSite": "mypage-prod"
}
}
}
```

And then run:
`ng deploy --configuration="production"`

This results with error:
`An unhandled exception occurred: The Firebase Project specified by your angular.json or .firebaserc is in conflict`

### Debug output

`An unhandled exception occurred: The Firebase Project specified by your angular.json or .firebaserc is in conflict`

Looking at the text I identified the issues being the lines 25 and 33 in this file:
https://github.com/angular/angularfire/blob/master/src/schematics/deploy/builder.ts

Problematic code parts:
```
if (!firebaseProject) {
throw new Error('Cannot detirmine the Firebase Project from your angular.json or .firebaserc');
}
if (firebaseProject !== defaultFirebaseProject) {
throw new Error('The Firebase Project specified by your angular.json or .firebaserc is in conflict');
}
```

and
```
const firebaseHostingSite = options.firebaseHostingSite || defulatFirebaseHostingSite;
if (!firebaseHostingSite) {
throw new Error(`Cannot detirmine the Firebase Hosting Site from your angular.json or .firebaserc`);
}
if (firebaseHostingSite !== defulatFirebaseHostingSite) {
throw new Error('The Firebase Hosting Site specified by your angular.json or .firebaserc is in conflict');
}
```

I can not make the sense out of this code.
Why would you prevent deploying any other value of the configuration other the default value?

Commenting out lines 25 and 33 results in the successful deployment of the desired configuration.

### Expected behaviour

Being able to configure different firebase projects and hosting sites for the same project

### Actual behaviour

Throwing errors when trying to use firebaseProject and firebaseHostingSite different from defaultFirebaseProject and defulatFirebaseHostingSite.

Edit: Duplicate of https://github.com/angular/angularfire/issues/3076 -> for some reason I thought that one was already closed

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。