angular / angular/angularfire

Multiple valueChange subscriptions for same collection leads to one subscription firing changes for another

Open
#2,740 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.8k
Forks
2.2k
Avg merge
22h 28m
Merged PRs (30d)
6

Description

### Version info

**Angular:** 10.0.9

**Firebase:** ^7.13.1

**AngularFire:** ^6.02

**Other (e.g. Ionic/Cordova, Node, browser, operating system):**

### How to reproduce these conditions

Create multiple valueChange subscriptions to the same collection (with a different query)
```
this.db.collection('/people/' + this.selectedPeopleId + '/messages', ref => ref.orderBy("createdDate").limitToLast(100)).valueChanges({idField: 'documentId'}).subscribe(messageUpdates =>
```
AND

```
this.db.collection('/people/' + this.selectedPeopleId + '/messages', ref => ref.where("type", ">", 0).limitToLast(100)).valueChanges({idField: 'documentId'}).subscribe(messageUpdates =>
```

In my case, I am unsubscribing from the second listener and recreating it with a different limitToLast value (though I'm unsure if that's necessary to reproduce)

### Debug output
none

### Expected behavior

Each valueChange listener should only fire results for itself

### Actual behavior

the first listener is returning valueChanges that match the query for the second listener.

Contributor guide

Open the contributing guide

Research direction

Start at the AngularFire collection().valueChanges() entry point and reproduce the two subscriptions against the same /people/.../messages collection with different queries. Verify that unsubscribing and recreating the second listener does not alter results delivered to the first; done means each subscription emits only its own query results.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, firebase, typescript
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.