angular / angular/angularfire

Update docs around Universal

Ouverte
#2,730 7 commentaires 3 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
7.8k
Forks
2.2k
Merge moyen
22 h 28 min
PR mergées (30 j)
6

Description

Currently the [docs provided](https://github.com/angular/angularfire/blob/master/docs/universal/getting-started.md) for running universal with firebase have not been updated in over 2 years. Comparing the code provided there with the sample project in this repo, it's easy to spot some differences:

- major changes in [server.ts](https://github.com/angular/angularfire/blob/master/sample/server.ts), notably the lack of AppServerModuleNgFactory and a module mapper, the inclusion of a firestore "protos" loader
- the absence of a webpack config file
- the universal cloud function has changed
- package scripts are different

Given the long running issues and ongoing challenges of doing universal with firebase, it would be awesome to have current docs on how to set this up in a way that is proven to work. If you are open to PRs I could open one.

It may also be worth maintaining a separate repo for a sample project that demonstrates serving routes that use firestore data so we can be sure what works when server-side rendering pages that need firestore data. It would be a great reference but also a great testing ground for when new versions of angular or firebase are released.

Thank you!

### Version info

**Angular: 11**

**Firebase: 8.0.0**

**AngularFire: 6.1.4**

**Other (e.g. Ionic/Cordova, Node, browser, operating system):**

### How to reproduce these conditions

n/a

**Steps to set up and reproduce**

n/a

**Sample data and security rules**

n/a

### Debug output

n/a

### Expected behavior

n/a

### Actual behavior

n/a

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez par docs/universal/getting-started.md et comparez-le avec le sample/server.ts actuel, les scripts du package, la configuration webpack et la fonction cloud universelle. Mettez à jour la documentation pour qu’elle corresponde au projet d’exemple, notamment les changements apportés à server.ts et le Firestore protos loader, puis vérifiez que la configuration Firebase Universal documentée fonctionne avec la structure actuelle du dépôt.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
angular, typescript
Domaine
documentation, web-dev
Type d'issue
Documentation
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
38/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.