Allow custom wsEndpoint for Playwright
- 主要语言
- TypeScript
- 星标
- 27k
- 派生
- 11.8k
- 平均合并
- 14 小时 23 分钟
- 30 天内合并 PR
- 162
描述
### Command
build
### Description
In our project, I've been trying to set up visual regression testing using Vitest, and to make the screenshot tests stable, we want to make those tests in the same environment, regardless of the developers' OS, which can impact the tests. When using Playwright as a browser provider, Vites allows for providing/overriding the WS endpoint, which is not respected & overridden in the unit test builder.
After a quick look at the code, presumably this is being dropped in `browser-provider.ts:164-87` - `providerFactory(..)` function is called with only `baseOptions`, and also, `plugins.ts:265-284` has some more overrides, and comments (`// CLI provider browser options override, if present`)
### Describe the solution you'd like
Ideally, as a developer, I'd like to have better control over the browser provider configuration, instead of having it implicitly overridden on the builder side.
These are the options that I have on my mind, both of them backward compatible with the existing API:
1. Allow full customization for the browser provider
The solution is as simple as not overriding the provider value if defined explicitly in `vitetest-base.config.ts`. This option would be backward compatible with the existing API, but might break the projects that've attempted to override the provider property and haven't noticed that it has no impact.
2. Add `wsEndpoint` property to the builder schema, and allow overriding the value from `angular.json`
Safer solution, but less flexible.
### Describe alternatives you've considered
All other alternatives require significant efforts to support, and require bypassing the Angular builders, or using a different framework for the same purpose.
I'm also happy to make a contribution, but first, I'd like to get an opinion, and maybe get more context on why the browser config is overridden from Angular's side.
贡献指南
调研方向
首先阅读 browser-provider.ts 第 164-187 行附近的内容,尤其是 providerFactory,然后检查 plugins.ts 第 265-284 行附近对 provider 的覆盖。跟踪 Playwright 配置如何传递到 Angular builder,并确定适当的向后兼容选项。完成的标准是,显式配置的 wsEndpoint 会被保留,而不是被隐式覆盖。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- angular, playwright, typescript
- 领域
- build-system, testing-qa, tooling
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100