angular / angular/angular-cli

Allow tests to pass without any test files (e.g. via Vitest `passWithNoTests`)

未關閉 適合新手
#33,055 1 則留言 3 個 reaction 已指派 0 人 在 GitHub 檢視
area: @angular/cli gemini-triaged
主要語言
TypeScript
星號
27k
分支
11.8k
平均合併
14 小時 23 分鐘
30 天內合併 PR
162

描述

### Command

test

### Description

Executing the **test** command on a project (app or lib) that does not have any test files (yet) will always lead to the following error message:

```txt
An exception occurred while getting runner-specific build options:
Error: No tests found matching the following patterns:
- Included: **/*.spec.ts, **/*.test.ts

Please check the 'test' target configuration in your project's 'angular.json' file.
```

However, many use cases exist where this behaviour is unintended. For example, a freshly generated project (even more so in a monorepo) will often start out without any real test cases defined, and it even may take some time for the first ones to be written. Even at this early point, though, I (as a developer) will usually want to already integrate test execution into a quality gate setup (like continuous integration).

Currently, the Angular CLI does not offer a way to allow the **test** command to succeed when no test files exist.

Related issue: https://github.com/nrwl/nx/issues/34241

### Describe the solution you'd like

The most pragmatic solution would probably be:

- Remove the custom Angular CLI check for test files, see: https://github.com/angular/angular-cli/blob/5adc92541433be23fc2246db5a199cf5c0dc9e67/packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts#L161-L170
- Instead, rely on Vitest and its `passWithNoTests` option - which is `false` by default, so no breaking change is to be expected (besides a different log message)

### Describe alternatives you've considered

Alternatively:

- The Angular CLI **test** command could also expose its own option. This would however collide with the respective Vitest option and thus require conflict resolution / priority checks. Plus, skimming the source code leads me to believe that the Angular CLI is currently not actively loading any custom Vite config, just passing it on - so changes here would presumably affect multiple places.

貢獻指南

開啟貢獻指南

研究方向

從 packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts 的第 161-170 行附近開始,這裡描述了自訂的無測試檔案檢查。檢視測試命令如何將 runner 選項傳遞給 Vitest,然後驗證沒有測試檔案的專案可以透過 Vitest 的 passWithNoTests 選項成功執行,同時預設行為維持不變。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
angular, typescript
領域
cli, testing
Issue 類型
功能
難度
2/5
預估耗時
1-3 小時
活躍度
冷清
描述清晰度
描述清楚
新手友好度
72/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。