angular / angular/angular-cli

The unit-test builder doesn't re-run test suites on changes to non-spec files

Aperta
#32,159 1 commento 3 reazioni 0 assegnatari Rivendicata da @maruthang Vedi su GitHub
angular/build:unit-test freq1: low severity3: broken type: bug/fix
Lingua principale
TypeScript
Stelle
27k
Fork
11.8k
Merge medio
14h 23m
PR unite (30g)
162

Descrizione

### Command

test

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

Storybook has support for running component tests using Vitest. When trying to build a POC with the `unit-test` builder, I ran into two issues.

- Storybook can't transform the stories because the compiled code leads to file with just an`import` as its contents.
- Making changes to files that aren't in the `include` array doesn't trigger tests to be re-run.

I was able to work around the code import issue with a plugin that re-exports the chunks from compiled files
https://github.com/brandonroberts/angular-storybook-vitest/blob/main/vitest-storybook-base.config.ts#L16

### Minimal Reproduction

https://github.com/brandonroberts/angular-storybook-vitest

1. Clone and install dependencies
2. Run `npm run test-storybook`
3. Note the tests pass
4. Make a change in one of the `src/stories/*.stories.ts` files
5. Note the build re-compiles but the tests aren't re-run.

The `test-storybook` target excludes the `stories` files because of the import issue so they are transpiled as-is.

https://github.com/brandonroberts/angular-storybook-vitest/blob/main/angular.json#L94

### Exception or Error

```text
No exception
```

### Your Environment

```text
Angular v21
```

### Anything else relevant?

_No response_

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia con la riproduzione collegata, il relativo angular.json test-storybook target e npm run test-storybook. Modifica una story non inclusa o un altro file rilevante e osserva se la build viene ricompilata senza rieseguire i test. Il lavoro è completato quando le modifiche ai file al di fuori dell’include array attivano nuovamente la test suite; a questa issue è già collegata una pull request aperta.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
angular, typescript
Ambito
build-system, testing
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
25/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.