angular / angular/angular-cli

feat: add option to disable route extraction feature

Ouverte
#31,340 14 commentaires 5 réactions 0 personnes assignées Voir sur GitHub
area: @angular/ssr feature feature: insufficient votes
Langage dominant
TypeScript
Étoiles
27k
Forks
11.8k
Merge moyen
14 h 23 min
PR mergées (30 j)
162

Description

### Command

build

### Description

When migrating apps to SSR, route extraction basically gets in the way and makes it harder to understand where the issue/error is coming from, as it tries to run before everything else either during build or server.

Instead of fixing other SSR related errors, I have to go and fix route extraction issues.

Also, there is no way to know if route extraction is happening. But even if it was possible the code would be full of checks on what mode is Angular running, and having to deal with all the states instead of just handling a normal case of -> open the url -> render angular -> serve html.

### Describe the solution you'd like

Add a flag to disable route extraction during build or serve totally, at least just for development purposes.
When routes are dynamically loaded based on config, having the extraction happen before the config can be loaded breaks the dynamic apps. If I build my app with a config that has 3 routes, and then on runtime I want to use another config.json file to load other routes (that also include the first three but with different configs), would cause my app to misbehave because of the initial extracted routes.

---

`NG_BUILD_PARTIAL_SSR=1` partially solves this by skipping the route extraction and doing it initial request.

### Repo
Comment out line 9 to better understand that serving or building the app is painful, even though on normal conditions opening localhost:4200/config.json loads fine.

https://github.com/eneajaho/dx-issue/blob/main/src/main.server.ts#L9

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez par la commande de build et le comportement existant de NG_BUILD_PARTIAL_SSR=1, puis reproduisez le problème en utilisant la ligne 9 de src/main.server.ts dans le dépôt d’exemple lié. Le travail est considéré comme terminé lorsqu’un flag peut désactiver l’extraction des routes pendant le build ou le serve, tout en permettant aux applications avec des routes chargées dynamiquement de continuer à fonctionner.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
angular, typescript
Domaine
build-system, web-dev
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.