Unhandled promise rejections aren't properly reported in tests
- Langage dominant
- TypeScript
- Étoiles
- 27k
- Forks
- 11.8k
- Merge moyen
- 14 h 23 min
- PR mergées (30 j)
- 162
Description
### Which @angular/* package(s) are the source of the bug?
Don't known / other
### Is this a regression?
Yes
### Description
In an Angular project that uses zone.js, unhandled promise rejections are not reported. In a zoneless Angular project, they are reported twice.
Steps to reproduce:
1. Create a new Angular project.
2. Paste the code below into a spec file.
3. `npm t`
```
it('triggers an unhandled rejection', function(done) {
Promise.reject(new Error('nope'));
// Make sure the unhandled rejection event has plenty of time to fire before
// Jasmine finishes running. This helps distinguish between timing issues
// (event is firing a bit later than usual) and the event not firing at all.
setTimeout(done, 1000);
});
```
Expected result: The spec should fail with a single "Unhandled promise
rejection: Error: nope" error.
Observed:
* If the project was set up zoneless, the spec fails with two copies of the expected error.
* Otherwise, the spec passes.
### Please provide a link to a minimal reproduction of the bug
https://github.com/sgravrock/ng-unhandled-rejection
### Please provide the exception or error you saw
```true
```
### Please provide the environment you discovered this bug in (run `ng version`)
```true
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ △ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 20.1.5
Node: 20.19.0
Package Manager: npm 10.8.2
OS: darwin arm64
Angular: 20.1.6
... common, compiler, compiler-cli, core, forms
... platform-browser, router
Package Version
------------------------------------------------------
@angular-devkit/architect 0.2001.5
@angular-devkit/core 20.1.5
@angular-devkit/schematics 20.1.5
@angular/build 20.1.5
@angular/cli 20.1.5
@schematics/angular 20.1.5
rxjs 7.8.2
typescript 5.8.3
zone.js 0.15.1
```
### Anything else?
_No response_
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Reproduisez le problème avec la spec fournie dans un nouveau projet Angular et exécutez `npm t`, en comparant les configurations zoneless et zone.js. Les fichiers pertinents du projet ne sont pas indiqués ; utilisez le setup de test et la reproduction minimale à l’adresse https://github.com/sgravrock/ng-unhandled-rejection comme points de départ. La tâche est terminée lorsque la spec signale exactement un rejet non géré dans les deux configurations.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- angular, typescript
- Domaine
- testing
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 42/100