angular / angular/angular-cli

Esbuild Web Worker Type Safety and Redundant tsconfig.worker.json

Ouverte
#30,676 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
angular/build:application area: @angular/build freq1: low severity1: confusing type: bug/fix
Langage dominant
TypeScript
Étoiles
27k
Forks
11.8k
Merge moyen
14 h 23 min
PR mergées (30 j)
162

Description

### Command

build

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

When using esbuild as the bundler for Angular projects, the support for web workers appears misleading in terms of type safety:

- In the previous webpack-based build setup, web workers had proper TypeScript type checking at build time.

- Currently, esbuild does not type-check web workers during build time. This is not documented or clearly communicated, leading to a false sense of correctness.

- Additionally, creating a project with a web worker generates a `tsconfig.worker.json`, which seems redundant because esbuild doesn't use it for type-checking. Also `builder` contains the `webWorkerTsConfig` option in the schema, as I understand it, this doesn't affect anything. This can confuse developers into thinking their web worker code is properly validated.

**Expected Behavior**

Either esbuild-based builder should perform type checking on web worker files, or there should be clear documentation and/or warnings that type-checking is not performed on workers.

**Current Behavior**

- No build-time type checking for worker code.

- Misleading tsconfig.worker.json is generated, giving false confidence in type safety.

### Minimal Reproduction

1. Generate a new Angular project with esbuild (Angular CLI 18+).
2. Add a web worker via ng generate web-worker.
3. Introduce a type error in the worker file.
4. Run ng build – no type error is reported.

### Exception or Error

```text

```

### Your Environment

```text
Any version with esbuild bundler.
```

### Anything else relevant?

_No response_

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez par reproduire le workflow Angular CLI esbuild décrit : générez un web worker, ajoutez une erreur de type et exécutez ng build. Examinez le tsconfig.worker.json généré ainsi que l’option webWorkerTsConfig du schéma du builder. Le travail est considéré comme terminé lorsque le comportement de vérification des types des workers est corrigé ou clairement documenté, et que la configuration trompeuse est traitée.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
angular, typescript
Domaine
build-system, cli
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.