angular / angular/angular-cli

Using overrideComponent breaks code coverage when testing with aot: true

Aberta
#30,127 9 comentários 12 reações 0 responsáveis Ver no GitHub
area: @angular/build devkit/build-angular:karma freq1: low severity3: broken type: bug/fix
Linguagem predominante
TypeScript
Estrelas
27k
Forks
11.8k
Merge médio
14h 23min
PRs com merge (30d)
162

Descrição

### Command

test

### Is this a regression?

- [ ] Yes, this behavior used to work in the previous version

### The previous version in which this bug was not present was

_No response_

### Description

When using `TestBed.overrideComponent` to stub a child component, the test code coverage is no longer accurate

### Minimal Reproduction

Generate a new app with latest CLI and add a component:

```
npx @angular/cli@20.0.0-next.6 new aot-coverage --defaults --no-routing
cd aot-coverage
ng g c user
```

Use app-user in app.html:
```html

Hello, aot-coverage

```

Edit angular.json to add "aot": true in the test section and run:
```
ng test --no-watch --code-coverage
```

Coverage is 100%
```
Statements : 100% ( 12/12 )
Branches : 100% ( 11/11 )
Functions : 100% ( 3/3 )
Lines : 100% ( 6/6 )
```

Now, in the app.spec.ts, add in `beforeEach`:

```ts
TestBed.overrideComponent(App, {
remove: {
imports: [User],
},
add: {
imports: [User],
}
});
```

(this happens with a proper stub of course but even removing the import and adding it back works to reproduce the issue)

Run the tests again:

```
ng test --no-watch --code-coverage
```

Coverage is now inaccurate because the template is not properly covered:
```
Statements : 58.33% ( 7/12 )
Branches : 90.9% ( 10/11 )
Functions : 66.66% ( 2/3 )
Lines : 66.66% ( 4/6 )
```

### Exception or Error

```text

```

### Your Environment

```text
Angular CLI: 20.0.0-next.6
Node: 22.14.0
Package Manager: npm 10.9.0
OS: darwin arm64

Angular: 20.0.0-next.7
... common, compiler, compiler-cli, core, forms
... platform-browser, router

Package Version
------------------------------------------------------
@angular-devkit/architect 0.2000.0-next.6
@angular-devkit/core 20.0.0-next.6
@angular-devkit/schematics 20.0.0-next.6
@angular/build 20.0.0-next.6
@angular/cli 20.0.0-next.6
@schematics/angular 20.0.0-next.6
rxjs 7.8.2
typescript 5.8.3
zone.js 0.15.0
```

### Anything else relevant?

_No response_

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Reproduza o problema no app gerado usando angular.json, app.spec.ts, TestBed.overrideComponent e os comandos fornecidos ng test --no-watch --code-coverage. Compare a cobertura antes e depois do override e, em seguida, rastreie os pontos de entrada dos testes do Angular CLI e da cobertura AOT. Está concluído quando o override não tornar mais imprecisa a cobertura do template do componente.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
angular, typescript
Domínio
build-system, testing
Tipo de issue
Bug
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Ativa
Clareza
Razoavelmente clara
Facilidade para iniciantes
48/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.