angular / angular/angular-cli

Dynamic base href (APP_BASE_HREF) for SSR

Abierto
#29,449 6 comentarios 11 reacciones 0 asignados Ver en GitHub
area: @angular/ssr feature feature: insufficient votes
Lenguaje dominante
TypeScript
Estrellas
27k
Forks
11.8k
Merge medio
14 h 23 min
PR fusionados (30 d)
162

Descripción

### Which @angular/* package(s) are relevant/related to the feature request?

_No response_

### Description

I'm using Angular as SSR multi tenant app.

We differentiate the clients per domain.

exemple:
potato.com/portal
tomato.com/citizen
onion-tickets.com

The majority from our clients use a specific base href and just a few serve the app on the root.

Right now it's difficult to work with angular with this setup, I had to do some 'stuff' on the SSR server to make it work.

We use a similar configuration for development too because it's easy to use domains rather than keep changing the client for localhost. This also allows to have many clients configured at the same time.

For the development we simply add on the OS hosts file `[CLIENT].local` and have nginx running on docker.
This has sped up a lot of developing time.

We are migrating from angular 16 to 19 and already preparing for the `AngularNodeAppEngine` because from what I saw in the docs it will be the default instead of the `ngExpressEngine` and `CommonEngine`.

At the moment there are (what I believe is regression) some things that worked in v16 that don't work in v19, and it impacts production and development.

I was preparing a repo with an example app to list those problems, but later realized that if the APP_BASE_HREF doesn't work like before, none of the other stuff matters.

This is part of the code that we use to make it work.

```typescript
// this will garantee that all the js are served from the right routes.
if (condition) {
res.render(indexHtml, {
req,
document: docWithoutBaseHref
});
} else {
res.render(indexHtml, {
req,
providers: [{ provide: APP_BASE_HREF, useValue: clientBaseHref }],
document: docWithBaseHref
})
}
```

As you can see by the name of the variables `docWithoutBaseHref` and `docWithBaseHref` we also manually parse the index file to add and remove the base href according to the domain and base href from the request.

I look it up in the code for v19 and the base href is retrieved from the html generated on the bundling process by the `.handle(req)` method from `AngularNodeAppEngine`, this break our app because we need to put the base href that came from the SSR request, instead of reading from a static file.

Is there a possibility to have this again working with Angular?

We tested with `commonEngine` and it has the same capabilities from `ngExpressEngine`.

The problem is that I don't think the angular team will maintain multiple packages, considering that the Server routes it's supported only by `AngularNodeAppEngine` and it will be the future of angular SSR and the other options will be deprecated.

We would like to know if something like this will be considered to be supported by `AngularNodeAppEngine`?

We can still keep using the packages/code that allow our customization, but this will only delay the problem and will force us to stay attached to an older version of angular. And prevent the use of new features.

We rely on this information to make a decision about how to move forward.

Thanks.
Cheers.

### Proposed solution

Allow for customization of html files from the SSR server instead of using hard coded values.
Allow to provide dynamic base href from SSR to the rendering of an angular route.

### Alternatives considered

Keep using an older angular version and never upgrade.
Move to another framework.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Empieza leyendo AngularNodeAppEngine.handle y compara su manejo de base-href con el comportamiento existente de CommonEngine y ngExpressEngine. Traza cómo APP_BASE_HREF y la solicitud llegan al renderizado SSR y, después, define qué requeriría admitir un base href específico de la solicitud. Se considera terminado cuando la salida SSR puede usar el base href proporcionado por la solicitud sin analizar manualmente el archivo index.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
angular, typescript
Área
backend, web-dev
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.