angular / angular/angular-cli

CLI doesn't allow custom builder to pass additional extensions when building app for i18n extractions

Offen
#27,264 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
area: @angular-devkit/build-angular devkit/build-angular:i18n freq1: low severity3: broken type: bug/fix
Vorherrschende Sprache
TypeScript
Sterne
27k
Forks
11.8k
Ø Merge
14 Std. 23 Min.
Gemergte PRs (30 T.)
162

Beschreibung

### Command

extract-i18n

### Description

We're in the process of migrating from webpack to esbuild.
To provide custom esbuild plugins we decided to use custom builder (https://github.com/just-jeb/angular-builders).

It went smooth until we realised that `extract-i18` no longer works. It ends successfully but `messages.xlf` is empty.

It turned out that angular checks `builderName` to choose which bundler to use.

To fix that I decided to implement custom `extract-i18n` builder that will trick `angular/cli` and force using esbuild -
https://github.com/just-jeb/angular-builders/pull/1711

For the record `nrwl/nx` did the same - https://github.com/nrwl/nx/pull/21802

**The issue** is that `angular/cli` will not let us pass any extensions during i18n application compilation.

https://github.com/angular/angular-cli/blob/1034bb155b58a5f18eecf56409a3ff99d2ca4474/packages/angular_devkit/build_angular/src/builders/extract-i18n/application-extraction.ts#L59

It may lead to inconsistency between build and extract flow, which I suppose may lead to issues with i18n.

### Describe the solution you'd like

We should be able to pass custom extensions as for regular app building.

(bonus) would be really nice if these `if (builderName === ...` are replaced by something that is custom builder friendly 🙏

### Describe alternatives you've considered

Alternatively we could rewrite whole `extract-i18n` builder, but as 95% of the code would be the same - it seems pointless

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start in packages/angular_devkit/build_angular/src/builders/extract-i18n/application-extraction.ts at the linked line and compare how regular application builds receive extensions. Verify that extract-i18n passes custom builder extensions during application compilation and that messages.xlf contains the extracted messages rather than being empty.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
angular, typescript
Bereich
build-system, cli, internationalization
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.