angular / angular/angular-cli

Custom vite middleware is not executed for CSS files

未关闭
#27,110 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
needs: more info
主要语言
TypeScript
星标
27k
派生
11.8k
平均合并
14 小时 23 分钟
30 天内合并 PR
162

描述

### Command

serve

### Description

We are in the process of migrating from using webpack to esbuild/vite.

For development purposes, we need a way to dynamically switch from one theme to another. At this point, we have achieved it by proxying CSS or image files depending on the host name.

After switching to Vite, it turned out that it could work the same, apart from the fact that for CSS resources, our middleware is never executed.

I found a piece of code that seems to be the root cause. The `AngularMemoryPlugin` handles CSS files in a specific way and never executes `next()`, which terminates the middleware chain.

https://github.com/angular/angular-cli/blob/3d7b5f78bdab834cb50c441296c9bf31f7a5e764/packages/angular_devkit/build_angular/src/tools/vite/angular-memory-plugin.ts#L163-L178

### Describe the solution you'd like

Ideally middleware chain should not be terminated in `AngularMemoryPlugin` for stylesheets (ie. `next()` should be called)

### Describe alternatives you've considered

In the worst case scenario, we will find another solution for our use case. However, since the issue only pertains to CSS files, it would be really helpful if the middleware is executed for these files as well.

贡献指南

打开贡献指南

调研方向

从 packages/angular_devkit/build_angular/src/tools/vite/angular-memory-plugin.ts 中第 163–178 行附近的 CSS 处理开始,跟踪 Vite middleware 链如何为样式表完成。确认此更改在保留 CSS 提供功能的同时,允许自定义 middleware 处理 CSS 资源,然后验证 serve 命令的行为。

由索引模型根据 Issue 内容生成。

评估

技术栈
angular, typescript, vite
领域
build-system, cli
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。