angular-ui / angular-ui/ui-router

When resolving an onBefore promise, the previous state is removed while async resolves are still pending.

未关闭
#3,827 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
stale
主要语言
TypeScript
星标
13.4k
派生
2.9k
PR 合并指标
30 天内没有已合并 PR

描述

This is a (check one box):

- [X] Bug Report

My version of UI-Router is: 1.0.28

# Bug Report

#### Current Behavior:

We can return a promise to `transitions.onBefore()`, if the promises resolves, I observe that the router starts the exit/retain/enter flow, and in turn removes the original state from the DOM.

The new state is only added after all async resolves are completed. In the mean time this leaves an empty dom or 'flickering' page.

#### Expected Behavior:

I expect the behavior to be the same to when I am not using an async onBefore, which is: Don't exit the original state until all async resolves are completed.

When returning a promise `transitions.onEnter()` the behavior is as expected. I can work with that.

If you think I am on to something here I am happy to provide a repro – otherwise feel free to ignore. Thanks for maintaining this useful project!

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。