andywer / andywer/use-inline-memo

Question: Can this library be used to memoize components inline?

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
164
Forks
3
Avg merge
17h 56m
Merged PRs (30d)
2

Description

Heya, nice project!

Just wanted to check if and how this library can be used to memoize components inline, e.g.:

```typescript
const Row = memo((props) => {
const { isLoadingRowAction, rowId } = props;

const thisLoadingRowAction = isLoadingRowAction === rowId;

return (
<>
{memo.circularFadeIn(


,
[thisLoadingRowAction]
)}

);
});
```

It appears that the component is one render behind, e.g. the CircularProgress doesn't fade in until the render **after** thisLoadingRowAction is `true` (even if it is false on the next render).

Any advice or guidance would be appreciated :)

Edit: Just did some logging:

![image](https://user-images.githubusercontent.com/5377480/154468463-e67b0ad3-32a9-43b9-8644-e263b3bd2dd9.png)

![image](https://user-images.githubusercontent.com/5377480/154468206-4fb81971-3928-4240-87ed-5af1f486a2c4.png)

Appears `in` is `true` in the second log but not in the first?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.