andywer / andywer/threads.js

expose `size` in `spawnWorker` callback

未關閉
#354 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
TypeScript
星號
3.5k
分支
173
PR 合併指標
30 天內沒有已合併 PR

描述

I'm trying to send the thread count to every worker. There are certain timeouts, like [file locks](https://www.npmjs.com/package/lockfile), used for allowing only one thread in at a time. I have the lock wait timeout set to a multiplier based on how many threads are running.

I was trying to do this:

```js
let threads;

function spawnWorker() {
return spawn(new Worker('foo', {
env: {
...process.env,

// useful for calculating timeouts based on how many other tasks are running
THREADS: threads,
},
}));
}

let pool = Pool(spawnWorker);

threads = pool.workers.length;
```

but since the initial pool spawning is synchronous, the env var gets hit before the `threads = pool.workers.length;` line.

My work around is of course:

```js
THREADS: require('os').cpus().length,
```

but I would prefer to be directly tied to your value so they are always in sync.

My proposition is the send the pool size down to the `spawnWorker` callback.

This:

```js
function spawnWorkers(spawnWorker, count) {
return createArray(count).map(() => ({
init: spawnWorker(),
runningTasks: []
}));
}
```

becomes

```js
function spawnWorkers(spawnWorker, count) {
return createArray(count).map(() => ({
init: spawnWorker(count),
runningTasks: []
}));
}
```

and my code becomes

```js
function spawnWorker(size) {
return spawn(new Worker('foo', {
env: {
...process.env,

// useful for calculating timeouts based on how many other tasks are running
THREADS: size,
},
}));
}
```

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。