andygrunwald / andygrunwald/go-gerrit

API-Methods: Return map/slice directly, rather than a pointer to one

未關閉
#53 0 則留言 2 個 reaction 已指派 0 人 在 GitHub 檢視
breaking-change enhancement
主要語言
Go
星號
106
分支
54
平均合併
7 小時 21 分鐘
30 天內合併 PR
3

描述

From @shurcooL in #52

> Modify both ListFiles and ListFilesReviewed to return map/slice directly, rather than a pointer to one. There doesn't appear to be any value in returning a pointer, it just makes the API harder to use. Slice/map are already reference types.

...

> Thoughts welcome.

> I know it's not consistent with other endpoints. But I couldn't bring myself to return *[]string or `*map[string]FileInfo`, since I was making a breaking API change to the method anyway.

> I think we should change all other methods that similarly return pointers to maps to be return just map values. If that's the agreed direction, doing this first step here makes sense. Otherwise, I should revert it.

This issue is about to make it consistent for this library :)

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。