android10 / android10/frodo2

Improve and simplify install script

未關閉
#3 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Java
星號
145
分支
13
PR 合併指標
30 天內沒有已合併 PR

描述

Right now the install script triggers multiple Gradle commands. In order to improve build time and simplify we could run just one command: ./gradlew clean assemble install.

The problem with doing that is Gradle configure all the subprojects and the sample apps have a dependency on the frodo2-plugin which does not exist at this time.

After doing some research, this is what I found:
- It is not possible to have a sample module and a regular plugin module to be built together as the dependency on the plugin by the sample project is in the buildscript{} block code.
- A way to deal with it is to remove the samples from the settings.gradle file so that any ./gradlew command from the top-level project does not touch the sample apps
- Example here: https://github.com/JakeWharton/hugo
- Con: They won't appear as modules in the project. Not sure this matters.
- A second way to deal with it is to publish the project publicly so that the sample always had a way to resolve the dependency on the plugin. We can add mavenLocal() on top so that it would fetch from local first but that would allow us to compile everything in one command
- Example here: https://github.com/square/sqldelight)
- Con: We need to make sure Gradle queries the local repo first. We can probably play with SNAPSHOT feature here

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。