android10 / android10/Android-CleanArchitecture-Kotlin

MovieDetailsViewModelTest always passed

Open
#116 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
4.8k
Forks
929
PR merge metrics
No merged PRs in 30d

Description

when running MovieDetailsViewModelTest, I found the test always pass though I changed assertion of a test
Also I set a debug inside LiveData, the test never reach the breakpoint

```
@Test fun test() {
val movieDetails = MovieDetails(0, "IronMan", "poster", "summary",
"cast", "director", 2018, "trailer")
coEvery { getMovieDetails.run(any()) } returns Right(movieDetails)
movieDetailsViewModel.movieDetails.observeForever {
with(it!!) {
id shouldEqualTo 1
title shouldEqualTo "IronMan"
poster shouldEqualTo "poster"
summary shouldEqualTo "summary"
cast shouldEqualTo "cast"
director shouldEqualTo "director"
year shouldEqualTo 2018
trailer shouldEqualTo "trailer"
}
}
runBlocking { movieDetailsViewModel.loadMovieDetails(0) }
}
```

This test should be fail, cause id should be **0** not **1**, but not sure why the test will pass

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.