andreypopp / andreypopp/react-css-components
Fix react unkown props
Ouverte
help wanted
- Langage dominant
- JavaScript
- Étoiles
- 672
- Forks
- 14
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
when using the following syntax with React `15.x`
```css
Label {}
Label:prop(mode == 'edit') {}
```
```jsx
```
React throws the following error:
```
Warning: Unknown prop `mode` on
tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
```
If I understand correctly what is being said [here](https://gist.github.com/jimfb/d99e0678e9da715ccf6454961ef04d1b), you should be able to remove unknown props. Basically, that means that the syntax you are currently using should be deprecated.
I would suggest keeping to the `variant` prop:
```jsx
```
If I understand correctly what is being said [here](https://gist.github.com/jimfb/d99e0678e9da715ccf6454961ef04d1b), you should be able to remove unknown props. Basically, that means that the syntax you are currently using should be deprecated.
I would suggest keeping to the `variant` prop:
```jsx
```
Tell me what you think.
**EDIT:** On second thoughts, the syntax is still very useful in many cases. For instance, you could choose to change the style of the component when `onClick` prop is set. I think it should be clearer in the doc that the library does not whitelist the props, and that you should use this feature only with props the component accepts.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.