andrewdavey / andrewdavey/immutable-devtools
Typo in renderIterableBody?
- Langage dominant
- JavaScript
- Étoiles
- 671
- Forks
- 32
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hi, I was reading through the code of this library, and read the `renderIterableBody` function. Here is the source for it:
```javascript
const renderIterableBody = (collection, mapper, options = {}) => {
if (options.sorted) {
collection = collection.sortBy((value, key) => key);
}
const children = collection
.map(mapper)
.toList();
const jsList = []
// Can't just call toJS because that will also call toJS on children inside the list
children.forEach(child => jsList.push(child))
return [ 'ol', listStyle, ...children ];
}
```
It seems that the author carefully crafted the `jsList` list, but then forgot to use it, and mistakenly used `children` instead.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.