andreamazz / andreamazz/AMScrollingNavbar

iOS 13 TabBar position is invalid after resuming device from lock

Ouverte
#373 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Swift
Étoiles
6k
Forks
628
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
First of all I would like to thank you again for this library, I use it in my apps and it makes the user experience much more pleasurable.
I've been updating my app for iOS 13 and I've noticed an invalid behaviour of the Scrolling NavBar, TabBar to be exact.
If the device is locked and the NavBar/TabBar is collapsed, then its position is invalid, when the device wakes back up. The problem can be seen in the gif I've attached.

The problem appears when also presenting other VCs onto the VC that has the ScollingNavBar, such as when presenting a SideMenu, in my case.

**To Reproduce**
Steps to reproduce the behavior:
1. Make the TabBar collapse.
2. Lock the device/simulator
3. Unlock the device, the TabBar will be visible, but in the .collapsed state, so once you scroll up, the TabBar moves above its normal position.
(Tested on iPhone 11 Pro Max iOS 13 Simulator, which didn't seem to happen on iOS 12 and below after fixing #321 )

**Expected behavior**
The TabBar should either be collapsed when waking, or have the correct state so it does not go above its normal position

**Screenshots**
Here's the gif of the problem. [gif](https://gph.is/g/4LNBQ3p)

After taking a look at the source code, I believe that the `scrollWithDelta` function gets called before the `didBecomeActive` function, thus making the `previousState` param always `.expanded` before the `didBecomeActive` checks its value. All of these are in the ScrollingNavigationController class.

I'll do some more digging and report here if I find a fix, any ideas are appreciated

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.