andreagrandi / andreagrandi/draftomen
Represent and persist multi-card logical picks
- Langage dominant
- Python
- Étoiles
- 0
- Forks
- 0
- Merge moyen
- 1 h 21 min
- PR mergées (30 j)
- 188
Description
## Problem
`PickMadeEvent`, `DraftPick`, pool persistence, idempotence, recovery, and completion reconciliation store one `chosen_grp_id`. Pick-Two selects two cards at one pack/pick coordinate, so logical-pick count and selected-card count are different invariants.
## Proposed change
Cleanly replace singular chosen-card contracts with an immutable collection of selected card IDs across events, draft state, and persistence. Migrate every direct caller in the same change. Preserve coordinate-level idempotence and add every selected card to the pool exactly once.
## Acceptance Criteria
- [ ] A logical pick stores one or more selected card IDs and rejects an empty selection.
- [ ] Quick/Premier/Traditional picks store one card; Pick-Two stores two cards at one coordinate.
- [ ] Logical-pick count and selected-card count are explicit and cannot be confused.
- [ ] Duplicate delivery of an identical multi-card pick is idempotent; conflicting replay is rejected consistently.
- [ ] Pending-pack recovery and completion reconciliation preserve every selected card exactly once.
- [ ] Existing persisted Quick Draft state has a tested clean migration or explicit compatibility strategy.
- [ ] All singular call sites are migrated; no deprecated alias remains.
- [ ] Focused pool/state tests and the changelog cover the new contract.
## Scope notes
No human pick-message parsing, ratings changes, or UI presentation.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Trace PickMadeEvent and DraftPick through pool persistence, pending-pack recovery, and completion reconciliation to map every singular chosen_grp_id caller. Run the focused pool/state tests while checking coordinate idempotence, migration compatibility, and selected-card counts. Done means all acceptance criteria pass and the changelog documents the new contract.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- backend, database
- Type d'issue
- Refactorisation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- Active
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100