andersao / andersao/l5-repository
Trait `CacheableRepository` - `getCacheMinutes` method was removed without breaking version?
Abierto
- Lenguaje dominante
- PHP
- Estrellas
- 4.2k
- Forks
- 880
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
From version 2.7.7 to 2.7.9, method `getCacheMinutes` had been replaced by `getCacheTime`.
As I investigated, the origin PR (#762) was marked as breaking changes, the released version must be 2.8 or whatever like that.
Follow new changes, I suggest:
- Keep origin `getCacheMinutes` method.
- Write new method called `getCacheSeconds`.
- Method `getCacheTime`: handle difference of ttl between Laravel version and call correspond method above.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.