andersao / andersao/l5-repository
[refactor] Criteria collection as extended collection class
Abierto
- Lenguaje dominante
- PHP
- Estrellas
- 4.2k
- Forks
- 880
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
I believe it would be better architecturally to have the criteria collection as more of a first class entity extending the base Collection class:
`CriteriaCollection extends \Illuminate\Support\Collection`
This would enable functionality around `push and pop` to be contained within the collection instance itself where it belongs.
Thoughts?
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.