anaralabs / anaralabs/lector

The page component create a div with wrong dimension when the PDF has rotation

Abierto
#81 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
395
Forks
39
Merge medio
7 h 7 min
PR fusionados (30 d)
12

Descripción

When using lector with a PDF that has rotation (i.e., 270°), the content is displayed correctly thanks to your generateViewports function that take into account the PDF rotation.

But the page component use raw width/height parameter instead of using the width/height from the calculated viewport. This lead to wrong div dimension (ui issue) and possible wrong layer positioning.

As consequence, when using your jumpToHighlightRects function, the layer is not placed correctly.

To address this issue I have create this pull request : #77

As example here the screenshot of the viewer with a PDF without rotation (landscape layout)

Image

And the same pdf that has been rotated to be in portrait layout:

Image

The PDF is always displayed properly (look at the purple border), but the page component use inverted dimensions.

Thanks

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.