anaralabs / anaralabs/lector

Issue with version since 3.2.0

Aberta
#59 3 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
TypeScript
Estrelas
395
Forks
39
Merge médio
7h 7min
PRs com merge (30d)
12

Descrição

Since v3.2.0, I upgraded pdfjs-dist to v5.0 but I got the following error with npm:

```
npm error Conflicting peer dependency: pdfjs-dist@4.10.38
npm error node_modules/pdfjs-dist
npm error peer pdfjs-dist@"^4.9" from @anaralabs/lector@3.2.0
npm error node_modules/@anaralabs/lector
npm error @anaralabs/lector@"^3.2.0" from the root project
```

I fix it with overrides on my package.json

```
"overrides": {
"@anaralabs/lector": {
"pdfjs-dist": "5.0.375"
}
},
```

Is that expected ?

In your https://github.com/anaralabs/lector/blob/main/packages/lector/package.json I saw that you have peerDependencies with

```
"pdfjs-dist": "^4.9",
```

Should it be >=4.9 ?

I'm not an expert with npm versionning and may be wrong

BTW, I also have warning with react 18.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.