amplitude / amplitude/experiment-ruby-server

Add open_timeout_millis configuration to AmplitudeExperiment::RemoteEvaluationConfig

未关闭
#71 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Ruby
星标
3
派生
6
PR 合并指标
30 天内没有已合并 PR

描述

## Summary

Currently, `AmplitudeExperiment::RemoteEvaluationConfig` allows configuring only `read_timeout` through the `fetch_timeout_millis` parameter.

Could you add `open_timeout_millis` to `AmplitudeExperiment::RemoteEvaluationConfig` to allow configuring the connection opening timeout?

```
config = AmplitudeExperiment::RemoteEvaluationConfig.new(
fetch_timeout_millis: 5000, # Read timeout
open_timeout_millis: 5000 # Open timeout (New)
)
```

A related discussion about this missing configuration occurred here:
[Issue #41 - Comment](https://github.com/amplitude/experiment-ruby-server/issues/41#issuecomment-1589858655).

## Motivations

Occasionally, requests to Amplitude fail due to excessive time required to establish a connection:

```
Failed to open TCP connection to api.lab.amplitude.com:443 (execution expired)"
```

Currently, the `open_timeout` value is not configurable and defaults to **60 seconds**, which can lead to a thread being blocked for an extended period. This impacts application performance, especially in multi-threaded environments where long waits can cause delays in processing other requests.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。