amplitude / amplitude/experiment-ios-client

Platform reports `iOS` while running on `macOS`

未關閉
#31 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Swift
星號
5
分支
17
平均合併
1 天 9 小時
30 天內合併 PR
3

描述

See this line of code: https://github.com/amplitude/experiment-ios-client/blob/main/Sources/Experiment/DefaultUserProvider.swift#L54

When using the SDK on macOS, I would expect this value to be `macOS`.
The Amplitude SDK seems to do this differently, since our analytics still show users for `macOS`. However, variants are fetched using `iOS` instead:

```
[Experiment] Fetch variants for user: ["platform": "iOS", "version": "2.0.0", "user_id": "XXX", "language": "English", "os": "ios 13.3.1.", "device_id": "XXX", "device_manufacturer": "Apple", "device_model": "arm64", "library": "experiment-ios-client/1.9.0"]
```

Note the value for `os` being `ios 13.3.1.`: the macOS version is correct, but it's prefixed with `iOS` instead of `macOS`. Due to this, our experiment didn't work as we were targeting `macOS` users.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。