amplitude / amplitude/Amplitude-TypeScript

Mac Catalyst support

Đang mở
#217 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug enhancement
Ngôn ngữ chính
TypeScript
Star
180
Fork
68
Merge trung bình
3 ngày 1 giờ
Pull request đã merge (30 ngày)
29

Mô tả

Hi, I wasn't sure if this was a new feature request or a bug, but the bug template seems more appropriate.

Does Amplitude React Native support running on Mac Catalyst?

## Expected Behaviour
Building a React Native app including Amplitude-TypeScript/packages/analytics-react-native should build successfully after enable Mac Catalyst support.

## Current Behaviour
I get a build failure with missing Swift symbols:

```
ld: warning: Could not find or use auto-linked library 'swiftUIKit'
Undefined symbols for architecture x86_64:
"__swift_FORCE_LOAD_$_swiftUIKit", referenced from:
__swift_FORCE_LOAD_$_swiftUIKit_$_amplitude_react_native in libamplitude-react-native.a(AppleContextProvider.o)
__swift_FORCE_LOAD_$_swiftUIKit_$_amplitude_react_native in libamplitude-react-native.a(AmplitudeReactNative-5b47eea62d6c653ce7e7364def6def16.o)
(maybe you meant: __swift_FORCE_LOAD_$_swiftUIKit_$_amplitude_react_native)
ld: symbol(s) not found for architecture x86_64
```

If I remove the Amplitude npm module ( `"@amplitude/analytics-react-native": "^0.4.0",` ) then my app builds OK.

I also tried this on the previous/legacy Amplitude RN npm module with similar errors (slightly different filenames).

## Possible Solution

I'm not sure of the solution but perhaps it's the same as https://github.com/amplitude/Amplitude-iOS/issues/327 which has been solved for the IOS library.

## Steps to Reproduce

1. Make a React Native project (I'm using v0.67.4)
2. `npm i @amplitude/analytics-react-native` and pod install
3. In XCode Project target > General > Deployment Info > tick "Mac Catalyst"
4. Build

## Environment
- JS SDK Version: 0.4.0
- Installation Method: npm
- React Native v0.67.4
- XCode 13.4.1
- MacOS 12.2.1

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.