amplitude / amplitude/Amplitude-TypeScript

Feature Request: Remove the @amplitude/analytics-react-native dependency with async storage and allow a custom storage implementation

Aperta
#1,283 5 commenti 25 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
TypeScript
Stelle
180
Fork
68
Merge medio
3g 1h
PR unite (30g)
29

Descrizione

## Summary

In `@amplitude/analytics-react-native` sdk, consider making `@react-native-async-storage/async-storage` an optional peer dependency instead of a required dependency. This would allow developers to provide their own storage implementation, such as `react-native-mmkv` or `expo-sqlite/kv-store`, without being forced to include AsyncStorage. This change would reduce APK size and avoid maintaining multiple local data sources.

## Motivations

The `@amplitude/analytics-react-native` SDK has `@react-native-async-storage/async-storage` as a required dependency. This forces us to include an additional local data source, even though we are already using `mmkv` for persistent local storage. It also adds unnecessary weight to the APK.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.