amplitude / amplitude/Amplitude-Node

Default retry behavior causes infinite event loop on error

Open
#87 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
73
Forks
20
PR merge metrics
No merged PRs in 30d

Description

There's a flaw in the default retry behavior on [line 59](https://github.com/amplitude/Amplitude-Node/blob/main/packages/node/src/retry/defaultRetry.ts#L59): whenever an error occurs, a new call stack is created and we immediately return.

Instead of returning, we should `await this._onEventsError` here and ensure that onEventsError is a promise.

Currently waiting for amplitude.flush causes the node.js event loop to never clear in the case of a rate limit error.

Here's an example integration test without a rate limit using jest:
Screen Shot 2021-03-13 at 5 28 10 PM

And here's one with a rate limit, notice how jest never exits:
Screen Shot 2021-03-13 at 5 28 42 PM

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.