amiaopensource / amiaopensource/vrecord

Fixed missing init of ffmpeg-bin locations before calling decklink list.

未關閉
#760 13 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Shell
星號
204
分支
53
平均合併
3 天 2 小時
30 天內合併 PR
10

描述

...but must be invited as collaborator (?) to create a pull request?

I'm using the ffmpeg binaries in `/usr/local/opt/ffmpegdecklink/bin` on my setups.
**It seems that if those are the primary/preferred executables, the shell variables were not initialized when trying to list the decklink devices.**

I've added a call to `_gather_ffmpeg_vars` in `_get_decklink_inputs` to fix that.

I'd also like to propose adding `/opt/ffmpeg/decklink/bin` to vrecord's search paths?
That would be more unix-compliant (/opt), and allow multiple ffmpeg-versions in parallel (as subfolders of /opt/ffmpeg).

Maybe even introduce a plain "PATH"-like variable, replacing the if-then-elif-fi blocks?

Anyways: So I'd like to provide a patch (pull-request). :smiley:

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。