amethyst / amethyst/specs

Can't use derive macro for Component if specs::Component is used under another name

Aperta
#719 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
2.6k
Fork
215
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The derive macro for components seems to be assuming that the literal string "Component" in my source code is going to point to `specs::Component`.

https://github.com/amethyst/specs/blob/d4435bdf496cf322c74886ca09dd8795984919b4/specs-derive/src/lib.rs#L72

This isn't true if I have my own `Component` type and I have done something like `use specs::Component as SComponent;`. It's also not true if I'm also using another library using similar code that wants ownership of the non-namespaced name `Component`.

The macro should be changed to use a fully-qualified `specs::Component`, so it can coexist with `Component`s from other crates.

Or am I doing something very wrong?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.