amethyst / amethyst/specs

Allow saveload to serialize/deserialize more than 8 component types

Aperta
#414 13 commenti 0 reazioni 1 assegnatario Rivendicata da @andreivasiliu Vedi su GitHub
discussion enhancement
Lingua principale
Rust
Stelle
2.6k
Fork
215
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I'm not sure if I'm doing something horribly wrong or commendably right, but I've hit the size limit of tuples that implement the `SerializeComponents`/`DeserializeComponents` traits, which is currently 8 component types.

This will not compile:
```
SerializeComponents::::serialize(
&(positions, sizes, shapes, rooms, in_rooms, player_controllers, velocities,
forces, aims, collision_sets, revolute_joints, jumps, animations),
&entities,
&markers,
&mut serializer
)
```

I think the proper solution here would be to implement `SerializeComponents` for any structure with `#[derive(SystemData)]`, but I don't know enough Rust to figure out how to do it myself.

Short-term I'd be happy with increasing the tuple size limit too.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.