amethyst / amethyst/rustrogueliketutorial

Chapter 7: ConvertSaveload requires serde as a dependency.

未关闭
#214 1 条评论 3 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
970
派生
166
PR 合并指标
30 天内没有已合并 PR

描述

While following along with chapter 7, I encountered a bunch of errors related to the use of the derive macro `ConvertSaveload` on the `WantsToMelee` component.

Further, nowhere in the tutorial does it explain that this will require serde as a dependency. I had to add the following to my cargo.toml:

```toml
[dependencies]
rltk = { git = "https://github.com/amethyst/bracket-lib" }
specs = { version = "0.17", features = ["serde"] } # added features = "serde"
serde = "1.0" # added serde dependency
```

Using the git version of rltk as per amethyst/bracket-lib#301
I also had to manually add the following additional imports:

```rust
use specs::saveload::{ConvertSaveload, Marker};
use specs::error::NoError;
use serde::{Serialize, Deserialize};
```

Failing to do so results in a series of complaints that various traits cannot be found. I'm still pretty new to rust, but I get the feeling that I shouldn't need to manually bring all of these traits into scope. I assume that this is the result of something not quite working right on the side of specs or specs-derive.

My suggestion would be to either remove the use of ConvertSaveload, or add clear instructions detailing the additional changes necessary to compile from that point on.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。