amethyst / amethyst/rustrogueliketutorial

Chapter 69 - Crash due to missing proc_target when using "weapon trait" items

Ouverte
#208 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
970
Forks
166
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

This line seems to crash the game if the player uses "weapon trait" generated weapons:
https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-69-mushrooms2/src/melee_combat_system.rs#L128

There doesn't seem to be anywhere that sets the correct `proc_target` in the generation code:
https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-69-mushrooms2/src/raws/rawmaster.rs#L160-L186

My guess is this gets fixed in a later chapter, but it would be nice if that was mentioned here. If this wasn't intentional, I think either adding something like `weapon.proc_target = Some("Target".to_string());` to rawmaster.rs or changing the line in melee_combat_system.rs to use `unwrap_or_default()` would fix this.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.