amethyst / amethyst/rustrogueliketutorial

RandomTable.roll() returning None fairly freqently.

Open
#205 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
970
Forks
166
PR merge metrics
No merged PRs in 30d

Description

To see the problem in action, get to a random map from chapter 45 on-wards.
The message "WARNING: We don't know how to spawn [None]!" should show up a number of times in the log.

Currently, whenever you roll 0, or exactly the sum of a number of item weights, nothing is spawned.
For example, if the first few items are weighted at [1,3,2,3,1...], then roll() would return "None" if the rng hits 0,1,4,6,9 or 10.
I'm assuming this is unintended behavior, but you can see pretty clearly why this happens in the code:
```rust
while roll > 0 {
if roll < self.entries[index].weight {
return self.entries[index].name.clone();
}

roll -= self.entries[index].weight;
index += 1;
}
```
There are two easy fixes that I can see. Both effectively just looping more:
```rust
while roll >= 0 { ...
```
or
```rust
while index < self.entries.len() { ..
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.