amethyst / amethyst/rustrogueliketutorial

5.24 Damage Over Time Kills Don't Give XP

Aperta
#164 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
970
Fork
166
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Because damage effects created by a DOT status condition don't include a creator, if the player uses the effect to kill a monster they don't gain any XP from the kill.

I was able to fix it with a little bit of difficulty (all thanks to a bug in specs):

In `components.rs`:
```rust
#[derive(Component, Debug, ConvertSaveload, Clone)]
pub struct DamageOverTime {
pub damage: i32,
pub creator: EntityOption,
}
```

This requires the entity-container workaround at https://github.com/amethyst/specs/issues/681#issuecomment-821274957 to store an optional entity.

In `rawmaster.rs`:

```rust
"damage_over_time" => $eb = $eb.with(DamageOverTime {
damage: effect.1.parse::().unwrap(),
creator: None.into(),
}),
```

Then, in `effects/damage.rs`, pass along the effect creator (converting to an EntityOption):

```rust
.with(DamageOverTime { damage: *damage, creator: effect.creator.into() })
```

And finally, in `ai/initiative_system.rs`, pass the status effect creator back into the effect system:

```rust
add_effect(
dot.creator.into(),
EffectType::Damage { amount: dot.damage },
Targets::Single {
target: status.target,
},
);
```

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.