amethyst / amethyst/bracket-lib

FastNoise::seeded() creates 0 noise

Open
#343 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.7k
Forks
126
PR merge metrics
No merged PRs in 30d

Description

Setting `frequency` to `0.0` in `FastNoise::seeded()`...

https://github.com/amethyst/bracket-lib/blob/0d2d5e6a9a8e7c7ae3710cfef85be4cab0109a27/bracket-noise/src/fastnoise.rs#L1764

... ensures we don't get any noise:

https://github.com/amethyst/bracket-lib/blob/0d2d5e6a9a8e7c7ae3710cfef85be4cab0109a27/bracket-noise/src/fastnoise.rs#L2020-L2023

Maybe it should be initialized to `1.0` just like for `new`?

https://github.com/amethyst/bracket-lib/blob/0d2d5e6a9a8e7c7ae3710cfef85be4cab0109a27/bracket-noise/src/fastnoise.rs#L1734-L1738

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.