amacneil / amacneil/dbmate

DBmate prints password if unable to parse string

未關閉
#784 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
Go
星號
7.4k
分支
380
平均合併
1 天 16 小時
30 天內合併 PR
2

描述

**Description**
I have a conn

- Version: 2.32.0
- Database: postgreSQL
- Operating System: Alpine

**Steps To Reproduce**

Setup connection string as env var like so `postgres://username:oRAND44@W)£+$\$r{5F?#x:$A\y^9\;&pzIS1&b_k@1.1.1.1:5432/db_name`
Try to run dbmate

**Expected Behavior**
If parsing fails parts of the password are not printed in the logs

**Actual Behavior**
The following is logged

> Error: parse "postgres://username:********@W)£+$\\$r{5F?": invalid character "\\" in host name

**Note**

While I understand that apparently I need to do some URL encoding of my password to make it work, I still expect there to be an option to NOT log passwords/connection string whatsoever.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。