amacneil / amacneil/dbmate

DBmate prints password if unable to parse string

Open
#784 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
7.4k
Forks
379
Avg merge
6m
Merged PRs (30d)
1

Description

**Description**
I have a conn

- Version: 2.32.0
- Database: postgreSQL
- Operating System: Alpine

**Steps To Reproduce**

Setup connection string as env var like so `postgres://username:oRAND44@W)£+$\$r{5F?#x:$A\y^9\;&pzIS1&b_k@1.1.1.1:5432/db_name`
Try to run dbmate

**Expected Behavior**
If parsing fails parts of the password are not printed in the logs

**Actual Behavior**
The following is logged

> Error: parse "postgres://username:********@W)£+$\\$r{5F?": invalid character "\\" in host name

**Note**

While I understand that apparently I need to do some URL encoding of my password to make it work, I still expect there to be an option to NOT log passwords/connection string whatsoever.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.